Migrate to MV3 (Chrome, Firefox, Edge) #1009

Sneezry · 2023-01-31T20:24:38Z

Fixes #565

Known issues

~~Backup export failed when setting a password~~
~~Browser sync is disabled by default, need to double confirm if it is as expected~~

Sneezry · 2023-02-02T20:47:12Z

Some scenario test is still on the way, but the code should be ready for review.

Sneezry · 2023-02-02T20:48:19Z

This PR only contains Chrome parts. Firefox and Edge MV3 migration should be in other PRs.

Sneezry · 2023-02-02T20:54:47Z

@rebornix Chrome, Firefox, and Edge are starting to migrate to MV3, MV2 will stop working in the next few months. There are many breaking changes in MV3, Safari may also have some updates. Once this PR has been merged, the Safari build may be broken.

mymindstorm · 2023-02-05T02:49:23Z

Just FYI, I might not be able to get to this until next Wednesday.

mymindstorm · 2023-02-21T03:32:45Z

I'm getting

/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:133
                if(isError) throw e;
                            ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (/home/mymindstorm/Projects/Authenticator-1/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/home/mymindstorm/Projects/Authenticator-1/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/home/mymindstorm/Projects/Authenticator-1/node_modules/webpack/lib/NormalModule.js:471:10)
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/webpack/lib/NormalModule.js:503:5
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/webpack/lib/NormalModule.js:358:12
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:236:3
    at context.callback (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at makeSourceMapAndFinish (/home/mymindstorm/Projects/Authenticator-1/node_modules/ts-loader/dist/index.js:90:5)
    at successLoader (/home/mymindstorm/Projects/Authenticator-1/node_modules/ts-loader/dist/index.js:68:9)
    at Object.loader (/home/mymindstorm/Projects/Authenticator-1/node_modules/ts-loader/dist/index.js:22:12)
    at LOADER_EXECUTION (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:119:14)
    at runSyncOrAsync (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:120:4)
    at iterateNormalLoaders (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
    at Array.<anonymous> (/home/mymindstorm/Projects/Authenticator-1/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (/home/mymindstorm/Projects/Authenticator-1/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
    at /home/mymindstorm/Projects/Authenticator-1/node_modules/graceful-fs/graceful-fs.js:123:16
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v18.12.1

when building. It goes away with export NODE_OPTIONS=--openssl-legacy-provider.

I think this might be fixed if we use a newer version of loader-runner (seems to be a dependency of webpack). Would that be easy to do here?

The service worker isn't registering properly on my Chrome: Service worker registration failed. Status code: 15.

Keyboard shortcuts seem to not be working due to manifest issue:

Sneezry · 2023-02-21T03:41:15Z

Can you load this build locally?
chrome.zip

mymindstorm · 2023-02-21T03:43:20Z

That build has same issues with the service worker and keyboard commands. (Chromium Version 110.0.5481.77)

Sneezry · 2023-02-21T03:46:57Z

Interesting... It works fine on my machine though...

mymindstorm · 2023-02-21T04:14:40Z

Interesting, I'll investigate further this weekend. What is your chrome version?

…

-------- Original message -------- From: Zhe Li ***@***.***> Date: 2/20/23 9:47 PM (GMT-06:00) To: Authenticator-Extension/Authenticator ***@***.***> Cc: Brendan Early ***@***.***>, Review requested ***@***.***> Subject: Re: [Authenticator-Extension/Authenticator] Migrate to Chrome MV3 (PR #1009) Interesting... It works fine on my machine though... [image]<https://user-images.githubusercontent.com/1621293/220242490-8e0dbd82-9afa-483d-b62b-1e09b59de843.png> [image]<https://user-images.githubusercontent.com/1621293/220242531-f1ca9d29-bc67-4728-ac96-e99b04c89066.png> [image]<https://user-images.githubusercontent.com/1621293/220242564-d99fe754-55a7-483d-97e9-3d7b66cf1b47.png> — Reply to this email directly, view it on GitHub<#1009 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGUAT3TEG4BOBV3HDW2IS7DWYQ3DZANCNFSM6AAAAAAUM4FOEQ>. You are receiving this because your review was requested.Message ID: ***@***.***>

mymindstorm · 2023-02-21T04:21:06Z

oops, I see that you've attached it.

Sneezry · 2023-03-09T04:50:37Z

I might find the root cause of the service work register issue.

Lots of API inside chrome are present only if your extension's manifest.json lists its associated permission name in "permissions" or in a special key
https://stackoverflow.com/a/73789284

The contextMenu is in optional permission, which means chrome.contextMenu should be undefined before the permission granted.

We can move it to required permission since I see no security risk about that.

@mymindstorm do you have any concern?

mymindstorm · 2023-03-09T04:51:23Z

Sorry for the lateness on this. I will get to it as soon as I can.

mymindstorm · 2023-03-09T04:51:47Z

I agree, I don't see a security concern there.

mymindstorm · 2023-04-02T19:23:31Z

I think I've resolved most of the issues I found. Please make sure to test on your end too to make sure I didn't miss anything.

mymindstorm · 2023-04-02T20:03:03Z

I am leaving the tests broken, I ran out of time to fix them.

Sneezry · 2023-04-10T03:35:01Z

I think I've resolved most of the issues I found. Please make sure to test on your end too to make sure I didn't miss anything.

Awesome! It works w/o problems on my side.

this prevents a dependency issue in the tests

mv3 makes code cov w/ istanbul virtually impossible due to restrictions on unsafe-eval

mymindstorm · 2024-03-15T23:31:54Z

Tests work again! We lost the ability for code coverage reporting, but that was half broken due to vue anyway.

mymindstorm

I really don't like how LocalStorage works.

Putting it as a global everywhere makes it easy to misuse (e.g. forget to load/store data from/to chrome.storage again). This should all be hidden behind a class. It's too easy to make mistakes with the current way.
Using the global var as a sort-of cache introduces the possibility of race conditions
We should name is something more descriptive, like userSettings
We know exactly what should be in LocalStorage/userSettings. There should be an interface for it instead of any.

For example, something like:

// UserSettings.d.ts
declare type StorageLocation = "sync" | "local";

interface UserSettings {
    storageLocation?: StorageLocation;
}

// LocalUserSettings.ts
export class LocalUserSettings {
  static async getUserSettings(): Promise<UserSettings> {
    return (await chrome.storage.local.get("userSettings"))?.userSettings || {};
  }

  static async setUserSettings(userSettings: UserSettings) {
    let mergedSettings = await getUserSettings();
    Object.assign(mergedSettings, userSettings);
    await chrome.storage.local.set({ userSettings: mergedSettings });
  }
}

What are your thoughts on this?

src/models/storage.ts

mymindstorm · 2024-03-18T02:05:30Z

Also, the migration for localStorage broke in Firefox. Will investigate when I have more time.

Sneezry · 2024-03-18T04:31:16Z

I really don't like how LocalStorage works.

Putting it as a global everywhere makes it easy to misuse (e.g. forget to load/store data from/to chrome.storage again). This should all be hidden behind a class. It's too easy to make mistakes with the current way.

Using the global var as a sort-of cache introduces the possibility of race conditions

We should name is something more descriptive, like userSettings

We know exactly what should be in LocalStorage/userSettings. There should be an interface for it instead of any.

For example, something like:
// UserSettings.d.ts
declare type StorageLocation = "sync" | "local";

interface UserSettings {
    storageLocation?: StorageLocation;
}

// LocalUserSettings.ts
export class LocalUserSettings {
  static async getUserSettings(): Promise<UserSettings> {
    return (await chrome.storage.local.get("userSettings"))?.userSettings || {};
  }

  static async setUserSettings(userSettings: UserSettings) {
    let mergedSettings = await getUserSettings();
    Object.assign(mergedSettings, userSettings);
    await chrome.storage.local.set({ userSettings: mergedSettings });
  }
}
What are your thoughts on this?

That makes sense. I will update the code later.

mymindstorm · 2024-03-18T04:50:22Z

Ok. I will be unavailable for the next week and a half, but can help out after that.

Sneezry · 2024-05-13T08:53:26Z

@mymindstorm I have updated the PR. Let's complete this PR before end of the next week (5/26).

Sneezry · 2024-05-20T04:46:51Z

Also, the migration for localStorage broke in Firefox. Will investigate when I have more time.

I didn't meet any error when migrating from MV2. Could you test the latest code to verify if the issue has been resolved?

mymindstorm · 2024-05-20T12:45:49Z

Sure. I've been sick since last week so it might take me some time to get to.

…

-------- Original message -------- From: Zhe Li ***@***.***> Date: 5/19/24 11:47 PM (GMT-06:00) To: Authenticator-Extension/Authenticator ***@***.***> Cc: Brendan Early ***@***.***>, Mention ***@***.***> Subject: Re: [Authenticator-Extension/Authenticator] Migrate to MV3 (Chrome, Firefox, Edge) (PR #1009) Also, the migration for localStorage broke in Firefox. Will investigate when I have more time. I didn't meet any error when migrating from MV2. Could you test the latest code to verify if the issue has been resolved? — Reply to this email directly, view it on GitHub<#1009 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGUAT3QA5A42QZRE66CI6GTZDF55BAVCNFSM6AAAAAAUM4FOESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGY2TSMRSG4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Sneezry · 2024-05-20T15:56:59Z

Oh, take care and recover soon! Brendan Early ***@***.***>于2024年5月20日周一20:46写道：

…

Sure. I've been sick since last week so it might take me some time to get to. -------- Original message -------- From: Zhe Li ***@***.***> Date: 5/19/24 11:47 PM (GMT-06:00) To: Authenticator-Extension/Authenticator ***@***.***> Cc: Brendan Early ***@***.***>, Mention ***@***.***> Subject: Re: [Authenticator-Extension/Authenticator] Migrate to MV3 (Chrome, Firefox, Edge) (PR #1009) Also, the migration for localStorage broke in Firefox. Will investigate when I have more time. I didn't meet any error when migrating from MV2. Could you test the latest code to verify if the issue has been resolved? — Reply to this email directly, view it on GitHub< #1009 (comment)>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AGUAT3QA5A42QZRE66CI6GTZDF55BAVCNFSM6AAAAAAUM4FOESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGY2TSMRSG4>. You are receiving this because you were mentioned.Message ID: ***@***.***> — Reply to this email directly, view it on GitHub <#1009 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAML2LK6LWI4FEUZLYDRO4TZDHWBJAVCNFSM6AAAAAAUM4FOESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQGM4TEMBYGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

Sneezry · 2024-05-24T12:21:08Z

Considering Google is required all extensions to migrate to MV3 by June, and leaving a week for CWS review, I will complete this PR by 5/26 anyway.

mymindstorm · 2024-05-26T22:07:03Z

Just FYI, starting to work on this. Will probably push something within 3-6 hours.

mymindstorm

From what I've seen it appears to work fine, outside of that crash I found. Although, I want to start automating E2E tests at some point.

* add compact theme * Add new strings This commit was automatically made by run 1641549669 * add icon for shortcut (#820) * strict ts * managed storage not available in safari. * use blob url to replace data url (#817) * Add flat theme. * add permissions management (#827) * add permissions management * hide required permission by default * update permission description * update strings Co-authored-by: Brendan Early <[email protected]> * Add new strings This commit was automatically made by run 1704482678 * Bump pathval from 1.1.0 to 1.1.1 (#852) Bumps [pathval](https://github.com/chaijs/pathval) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/chaijs/pathval/releases) - [Changelog](https://github.com/chaijs/pathval/blob/master/CHANGELOG.md) - [Commits](chaijs/pathval@v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: pathval dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.1 to 2.6.7 (#853) Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 2.6.7. - [Release notes](https://github.com/node-fetch/node-fetch/releases) - [Commits](node-fetch/node-fetch@v2.6.1...v2.6.7) --- updated-dependencies: - dependency-name: node-fetch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.7 to 1.19.10 (#873) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.7 to 1.19.10. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.7...v1.19.10) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 (#884) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ansi-regex from 3.0.0 to 3.0.1 (#885) Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v3.0.0...v3.0.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump urijs from 1.19.10 to 1.19.11 (#886) Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.10 to 1.19.11. - [Release notes](https://github.com/medialize/URI.js/releases) - [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md) - [Commits](medialize/URI.js@v1.19.10...v1.19.11) --- updated-dependencies: - dependency-name: urijs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * add autofill command (#831) * add autofill command * address comment * Add 'wasm-unsafe-eval' to custom CSP (fix #906) It seems that some dependencies (at least argon2-browser) require allowing WebAssembly at the CSP level. Recent Firefox allows that by default, but having your own CSP means this extension won't be able to benefit from this automatically. * revert unnecessary change * Update readme * Browser componnet * isFirefox * isEdge. * 💄 * TypeScript does not like type annotation for catch. * 💄 * fix build * update theme for safari * fix local download * update to latest * minimal change * 💄 * fix redundant theme option * Update translations from crowdin * Update readme for safari. * Use `&&` * Add new strings This commit was automatically made by run 2680600562 * Bump terser from 4.8.0 to 4.8.1 (#929) Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump loader-utils from 1.4.0 to 1.4.1 (#970) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump qs from 6.9.4 to 6.11.0 (#985) Bumps [qs](https://github.com/ljharb/qs) from 6.9.4 to 6.11.0. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.9.4...v6.11.0) --- updated-dependencies: - dependency-name: qs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump json5 from 1.0.1 to 1.0.2 (#993) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump cookiejar from 2.1.2 to 2.1.4 (#1006) Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix disable backup policy not working issue (#1050) * 6.3.5 * typo * fix typo (#1144) * add import QR images/OTP URLs buttons to add account page * Add new strings This commit was automatically made by run 8076854721 * Migrate to MV3 (Chrome, Firefox, Edge) (#1009) * Migrate to MV3 * fix entry type * fix default storage area * fix mv3 migration errors * further CI fixes * Fix disable backup policy not working issue (#1050) * 6.3.5 * typo * Fix bad practice with argon2-browser * Remove 'offline_enabled' from manifest * update test runner and coverage for mv3 * don't use dev config by default * fix typo (#1144) * add import QR images/OTP URLs buttons to add account page * Migrate to MV3 * fix entry type * fix default storage area * fix mv3 migration errors * further CI fixes * Fix bad practice with argon2-browser * Remove 'offline_enabled' from manifest * update test runner and coverage for mv3 * don't use dev config by default * dump version * update manifest * fix ff csp * remove artifact * rename test files * move syncTimeWithGoogle out of popup.ts this prevents a dependency issue in the tests * fix the tests, remove code coverage mv3 makes code cov w/ istanbul virtually impossible due to restrictions on unsafe-eval * remove testing code * refactor user settings (#1191) * remove out-of-date eslint comments * fix user settings migration issue * fix user setting migration issue * fix edge errors * fix edge issues * update firefox permissions * remove all_urls permission since Firefox has supported activeTab * fix firefox crash due to functions getting added to usersettings object --------- Co-authored-by: Brendan Early <[email protected]> Co-authored-by: Zhe Li <[email protected]> Co-authored-by: spaette <[email protected]> Co-authored-by: vuittont60 <[email protected]> * Add new strings This commit was automatically made by run 9249787733 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Zhe Li <[email protected]> Co-authored-by: rebornix <[email protected]> Co-authored-by: Brendan Early <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Frederik Braun <[email protected]> Co-authored-by: Peng Lyu <[email protected]> Co-authored-by: spaette <[email protected]> Co-authored-by: vuittont60 <[email protected]>

Sneezry force-pushed the mv3 branch from 9804cde to 5ac80ff Compare February 1, 2023 06:42

Sneezry changed the title ~~WIP: Migrate to MV3~~ WIP: Migrate to Chrome MV3 Feb 1, 2023

Sneezry force-pushed the mv3 branch 2 times, most recently from 958efa5 to e5e99e8 Compare February 1, 2023 20:30

Migrate to MV3

5a79d41

Sneezry force-pushed the mv3 branch from e5e99e8 to 5a79d41 Compare February 1, 2023 21:12

Sneezry added 2 commits February 3, 2023 03:40

fix entry type

b779d64

fix default storage area

6fc6164

Sneezry marked this pull request as ready for review February 2, 2023 20:47

Sneezry requested a review from mymindstorm February 2, 2023 20:47

Sneezry changed the title ~~WIP: Migrate to Chrome MV3~~ Migrate to Chrome MV3 Feb 2, 2023

fix mv3 migration errors

88053dc

mymindstorm force-pushed the mv3 branch from 0b0eab1 to 88053dc Compare April 2, 2023 19:45

further CI fixes

35bddef

mymindstorm added 4 commits March 15, 2024 16:03

remove artifact

9db043b

rename test files

22e9c21

move syncTimeWithGoogle out of popup.ts

7f1368c

this prevents a dependency issue in the tests

fix the tests, remove code coverage

013904a

mv3 makes code cov w/ istanbul virtually impossible due to restrictions on unsafe-eval

remove testing code

053d5c4

mymindstorm requested changes Mar 18, 2024

View reviewed changes

src/models/storage.ts Outdated Show resolved Hide resolved

src/models/storage.ts Outdated Show resolved Hide resolved

Sneezry and others added 2 commits May 13, 2024 16:48

refactor user settings (#1191)

e8083ae

remove out-of-date eslint comments

78d45bb

Sneezry requested a review from mymindstorm May 13, 2024 08:56

Sneezry added 2 commits May 15, 2024 14:12

fix user settings migration issue

c2738b8

fix user setting migration issue

7c845be

fix edge errors

adeaf82

Sneezry added 3 commits May 23, 2024 12:25

fix edge issues

6efa4ec

update firefox permissions

4932212

remove all_urls permission since Firefox has supported activeTab

78d7129

fix firefox crash due to functions getting added to usersettings object

a5ef095

mymindstorm approved these changes May 26, 2024

View reviewed changes

Sneezry merged commit df0b859 into dev May 27, 2024
10 checks passed

Sneezry mentioned this pull request Sep 2, 2024

Fix toolbar button shortcut (#1274) #1288

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to MV3 (Chrome, Firefox, Edge) #1009

Migrate to MV3 (Chrome, Firefox, Edge) #1009

Sneezry commented Jan 31, 2023 •

edited by mymindstorm

Loading

Sneezry commented Feb 2, 2023

Sneezry commented Feb 2, 2023

Sneezry commented Feb 2, 2023

mymindstorm commented Feb 5, 2023

mymindstorm commented Feb 21, 2023 •

edited

Loading

Sneezry commented Feb 21, 2023

mymindstorm commented Feb 21, 2023 •

edited

Loading

Sneezry commented Feb 21, 2023

mymindstorm commented Feb 21, 2023 via email

mymindstorm commented Feb 21, 2023

Sneezry commented Mar 9, 2023

mymindstorm commented Mar 9, 2023

mymindstorm commented Mar 9, 2023

mymindstorm commented Apr 2, 2023

mymindstorm commented Apr 2, 2023

Sneezry commented Apr 10, 2023

mymindstorm commented Mar 15, 2024

mymindstorm left a comment •

edited

Loading

mymindstorm commented Mar 18, 2024

Sneezry commented Mar 18, 2024

mymindstorm commented Mar 18, 2024

Sneezry commented May 13, 2024

Sneezry commented May 20, 2024

mymindstorm commented May 20, 2024 via email

Sneezry commented May 20, 2024 via email

Sneezry commented May 24, 2024

mymindstorm commented May 26, 2024

mymindstorm left a comment •

edited

Loading

Migrate to MV3 (Chrome, Firefox, Edge) #1009

Migrate to MV3 (Chrome, Firefox, Edge) #1009

Conversation

Sneezry commented Jan 31, 2023 • edited by mymindstorm Loading

Known issues

Sneezry commented Feb 2, 2023

Sneezry commented Feb 2, 2023

Sneezry commented Feb 2, 2023

mymindstorm commented Feb 5, 2023

mymindstorm commented Feb 21, 2023 • edited Loading

Sneezry commented Feb 21, 2023

mymindstorm commented Feb 21, 2023 • edited Loading

Sneezry commented Feb 21, 2023

mymindstorm commented Feb 21, 2023 via email

mymindstorm commented Feb 21, 2023

Sneezry commented Mar 9, 2023

mymindstorm commented Mar 9, 2023

mymindstorm commented Mar 9, 2023

mymindstorm commented Apr 2, 2023

mymindstorm commented Apr 2, 2023

Sneezry commented Apr 10, 2023

mymindstorm commented Mar 15, 2024

mymindstorm left a comment • edited Loading

Choose a reason for hiding this comment

mymindstorm commented Mar 18, 2024

Sneezry commented Mar 18, 2024

mymindstorm commented Mar 18, 2024

Sneezry commented May 13, 2024

Sneezry commented May 20, 2024

mymindstorm commented May 20, 2024 via email

Sneezry commented May 20, 2024 via email

Sneezry commented May 24, 2024

mymindstorm commented May 26, 2024

mymindstorm left a comment • edited Loading

Choose a reason for hiding this comment

Sneezry commented Jan 31, 2023 •

edited by mymindstorm

Loading

mymindstorm commented Feb 21, 2023 •

edited

Loading

mymindstorm commented Feb 21, 2023 •

edited

Loading

mymindstorm left a comment •

edited

Loading

mymindstorm left a comment •

edited

Loading